-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Multikey as supported vm type #1720
Merged
TimoGlastra
merged 4 commits into
openwallet-foundation:main
from
dbluhm:feature/multikey
Jan 31, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
packages/core/src/modules/dids/domain/verificationMethod/Multikey.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import type { VerificationMethod } from './VerificationMethod' | ||
|
||
import { Key } from '../../../../crypto/Key' | ||
import { AriesFrameworkError } from '../../../../error' | ||
|
||
export const VERIFICATION_METHOD_TYPE_MULTIKEY = 'Multikey' | ||
|
||
type GetMultikeyOptions = { | ||
did: string | ||
key: Key | ||
verificationMethodId?: string | ||
} | ||
|
||
/** | ||
* Get a Multikey verification method. | ||
*/ | ||
export function getMultikey({ did, key, verificationMethodId }: GetMultikeyOptions) { | ||
if (!verificationMethodId) { | ||
verificationMethodId = `${did}#${key.fingerprint}` | ||
} | ||
|
||
return { | ||
id: verificationMethodId, | ||
type: VERIFICATION_METHOD_TYPE_MULTIKEY, | ||
controller: did, | ||
publicKeyMultibase: key.fingerprint, | ||
} | ||
} | ||
|
||
/** | ||
* Check whether a verification method is a Multikey verification method. | ||
*/ | ||
export function isMultikey( | ||
verificationMethod: VerificationMethod | ||
): verificationMethod is VerificationMethod & { type: 'Multikey' } { | ||
return verificationMethod.type === VERIFICATION_METHOD_TYPE_MULTIKEY | ||
} | ||
|
||
/** | ||
* Get a key from a Multikey verification method. | ||
*/ | ||
export function getKeyFromMultikey(verificationMethod: VerificationMethod & { type: 'Multikey' }) { | ||
if (!verificationMethod.publicKeyMultibase) { | ||
throw new AriesFrameworkError( | ||
`Missing publicKeyMultibase on verification method with type ${VERIFICATION_METHOD_TYPE_MULTIKEY}` | ||
) | ||
} | ||
|
||
return Key.fromFingerprint(verificationMethod.publicKeyMultibase) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fingerprint was supposed to give a fingerprint of the key, and it also is a multibase encoding. Might be good to add a toMultibase and fromMultibase options and also support e.g. base64 encoding as described in the di spec. But fine for now |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have this in keyDidMapping (a higher level), so i don't know when it'll reach this, but i see we have the same duplication for JsonWebKey2020 so it's okay for now.
We can refactor it a bit later on