refactor(anoncreds)!: combine anoncreds packages #1723
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
There was a problem hiding this comment.
I think this will certainly simplify agent setup. There are a few things that maybe can be improved or simplified later on, like the injection symbols usage (not sure if it's worth to keep using them if we'll support a single implementation) and the test structure, but I think it is perfectly fine for now.
| @@ -40,6 +42,11 @@ export class AnonCredsModule implements Module { | |||
| dependencyManager.registerSingleton(AnonCredsLinkSecretRepository) | |||
| dependencyManager.registerSingleton(AnonCredsRevocationRegistryDefinitionRepository) | |||
| dependencyManager.registerSingleton(AnonCredsRevocationRegistryDefinitionPrivateRepository) | |||
|
|
|||
| // TODO: should we allow to override the service? | |||
There was a problem hiding this comment.
It can be useful, but we'll still being importing anoncreds-rs native library, so it would be still inconvenient if we really want to use other library.
There was a problem hiding this comment.
Yes but a model could exist where we make passing anoncreds optional and you provide your own services implementation. You'll only depend on the HL/anoncreds-shared package in this case which doesn't include the heavy AnonCreds-rs
Signed-off-by: Timo Glastra <timo@animo.id>
Combines the two anoncreds packages into
@credo-ts/anoncredsto hopefully simplify setup a bit