Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Frame fails when a type with an optional or nullable field is used #272

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

charsleysa
Copy link
Contributor

Types such as the following currently fail when trying to make the nested fields selectively discloseable:

type PID = {
    given_name: string;
    address?: {
        country: string;
    }
};

const disclosureFrame: DisclosureFrame<PID> = {
    _sd: ['given_name'],
    address: {
        _sd: ['country']
    }
};

Signed-off-by: Stefan Charsley charsleysa@gmail.com

Signed-off-by: Stefan Charsley <charsleysa@gmail.com>
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR :)

@lukasjhan lukasjhan merged commit ed907e3 into openwallet-foundation:main Jan 29, 2025
8 checks passed
@cre8
Copy link
Contributor

cre8 commented Jan 29, 2025

Thank you @charsleysa for the fix! The latest version was released with it some minutes ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants