Add overflow: visible to svgs used for brackets and such.
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am seeing clipping occur on the bottoms of brackets and braces in some instances. Adding `overflow: visible` prevents this. I don't think there is ever a situation where these svgs should be clipped, so I don't think there is any downside to adding this. At the default zoom level for me in both Firefox and Chrome the bottom of a brace or bracket is clipped. If I increase or decrease the zoom level the clipping stops. It also seems to usually only happen in the first MathQuill input on the page, and not the later ones. So overall very odd. Also run `npx update-browserslist-db@latest` because I am seeing warnings about that.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Feb 5, 2025
This corresponds to openwebwork/mathquill#36, and just upgrades to the now published version with that tweak.
pstaabp
approved these changes
Feb 11, 2025
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Feb 12, 2025
This corresponds to openwebwork/mathquill#36, and just upgrades to the now published version with that tweak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the default zoom level for me in both Firefox and Chrome the bottom of a brace or bracket is clipped. If I increase or decrease the zoom level the clipping stops. It also seems to usually only happen in the first MathQuill input on the page, and not the later ones. Also, this does not happen with the MathQuill test pages. It only happens in webwork2. So this may have something to do with some Bootstrap css.
Here is a screen shot of what I am seeing:
Adding
overflow: visibleprevents this. I don't think there is ever a situation where these svgs should be clipped, so I don't think there is any downside to adding this.Also run
npx update-browserslist-db@latestbecause I am seeing warnings about that.