Update the quickMatrixEntry.pl macro #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this pull request and #948, I believe that all jquery-ui usage has now been removed from the webwork2 and pg code. Perhaps all jquery usage in general? I am not entirely certain of that though. |
drgrice1
force-pushed
the
quick-matrix-entry-update
branch
from
caaecb8 to
43b72d6
Compare
|
The |
drgrice1
force-pushed
the
quick-matrix-entry-update
branch
2 times, most recently
from
5f85050 to
d7eaf9f
Compare
This removes the dependence on jQuery and jquery-ui. This also adds an ans_rule method for PGML usage. The POD documentation that was added explains only how to use the macro in this way. There is deprecated code for backwards compatibility, although I would gladly remove that. The only known problem that uses this macro is in the pg repository. It is the file `t/matrix_tableau_tests/tableau_javascript.pg`. I would also like to delete that file.
drgrice1
force-pushed
the
quick-matrix-entry-update
branch
from
d7eaf9f to
713464a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependence on jQuery and jquery-ui.
This also adds an ans_rule method for PGML usage. The POD documentation that was added explains only how to use the macro in this way.
There is deprecated code for backwards compatibility, although I would gladly remove that. The only known problem that uses this macro is in the pg repository. It is the file
t/matrix_tableau_tests/tableau_javascript.pg. I would also like to delete that file.