Support for custom permission levels not in the userRoles hash (replacement of #2629) #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the active %userRoles hash. Will prevent Accounts Manager from failing. See openwebwork#2625 but when editing a user with such a value, will only allow choosing a defined level.
somiaj
approved these changes
Jan 23, 2025
|
If you want to test this without going into the database, just add a custom role in localOverrides.conf such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #2629 and makes the changes requested for that pull request.
Currently an permission level that is not in the userRoles hash causes an exception to be thrown if the accounts manager is loaded. This shows "Unknown: n" (where n is the unknown level) in that case and no exception is thrown.
The requested change is that the
maketextcall in #2629 was not valid.