WIP: Convert project to use pipenv

[okraits]

This PR has the goal of converting this project to use pipenv (https://pipenv.readthedocs.io/) for its development and deployment. It can serve as an example and evaluation of the conversion process.

For simplicity, I removed the method to parse the requirements.txt file from setup.py and inserted the dependencies directly, that's how other projects do it, too - https://github.com/requests/httpbin for example.

It also makes sense to keep both dependency lists - see https://pipenv.readthedocs.io/en/latest/advanced/#pipfile-vs-setuppy.

Also, I didn't find a possibility to parse the Pipfile so far (pipenv is the reference implementation - see https://github.com/pypa/pipfile), but we can add that later.

Todos:

• fix travis build
• optional: in setup.py, read dependencies from Pipfile

Related issue in pipenv: pypa/pipenv#1263

[nemesifier]

The only way that comes to my mind to solve the duplication without requiring pipenv to install the package (which would be bad as explained by them on that issue you linked), is to parse the Pipfile using a regular expression that splits in groups based on encoutering square brackets, and then processing each line in the [packages] further. Sounds a bit overkill, but if we manage to do this well we could send a patch to setuptools and get it included there.

We could split this task into multiple GCI tasks as well.

[okraits]

Using the method described in pypa/pipenv#1263 (comment) I modified the Pipfile so that when issuing pipenv install it installs the local openwisp-controller module (pulling in the dependencies from setup.py.

This means that the runtime dependencies are defined in the install_requires list in setup.py and the development/test requirements are defined in Pipfile.

It would also be possible to define another list for dev packages in setup.py but the way I'm using is more clean IMO because there's a clean separation between packaging (setup.py) and development/deployment (Pipfile).

[nemesifier]

@okraits Cool!
The .travis.yml file needs to be updated to reflect these changes otherwise the build will fail. See also my other minor comment.

[nemesifier]

final new line is missing here

[okraits]

Yes, already noticed it in the diff. Fixed 😀

I need to fix the travis build tomorrow.

[coveralls]

Coverage decreased (-0.2%) to 99.374% when pulling 87c42ce on TDT-AG:master-pipenv into fba9b8f on openwisp:master.

[jerbob]

I'd recommend adding pipenv tasks to replace the current flake8, isort and runtests.py commands. I'm hoping to implement this in a PR to the TDT-AG repo, so this should be part of the PR soon.

[nemesifier]

@anonguy great 👍