[chores] Improved password expiration warning email #367 #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Feb 14, 2024
openwisp_users/tasks.py
Outdated
| # Avoid overloading the SMTP server by sending multiple | ||
| # emails continuously. | ||
| email_counts += 1 | ||
| if email_counts > 10: |
There was a problem hiding this comment.
Suggested change
| if email_counts > 10: | |
| if email_counts >= 10: |
I think the current version of the code adds the sleep every 11 emails, not every 10.
nemesifier
requested changes
Feb 14, 2024
| @@ -0,0 +1,5 @@ | |||
| {% load i18n %} | |||
|
|
|||
| <p>{% blocktrans with expiry_date=expiry_date|date:"Y-m-d" %}We inform you that the password for your account {{ username }} will expire in 7 days, precisely on {{ expiry_date }}.{% endblocktrans %}<p> | |||
There was a problem hiding this comment.
Please use a date format which is human friendly.
nemesifier
reviewed
Feb 15, 2024
openwisp_users/tasks.py
Outdated
| @@ -49,17 +54,31 @@ def password_expiration_email(): | |||
| ) | |||
| .filter(query) | |||
| ) | |||
| email_counts = 0 | |||
There was a problem hiding this comment.
if we want to sleep at the 10th email we have to set this to 1
There was a problem hiding this comment.
The test here creates only 10 users, and the sleep is triggered after sending 10 emails.
nemesifier
approved these changes
Feb 15, 2024
nemesifier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367