Skip to content

Commit

Permalink
PR #18387: [ROCm] Disable failing subtests for command_buffer_schedul…
Browse files Browse the repository at this point in the history
…ing_test

Imported from GitHub PR #18387

Disabling `Conditional` and `While` subtests in `command_buffer_scheduling_test`  since ROCm does not support conditional nodes in the hip graph
Copybara import of the project:

--
ba4396e by Milica Makevic <Milica.Makevic@amd.com>:

Disable Conditional and While subtests for ROCm

Merging this change closes #18387

COPYBARA_INTEGRATE_REVIEW=#18387 from ROCm:fix_command_buffer_scheduling_test ba4396e
PiperOrigin-RevId: 686834433
  • Loading branch information
mmakevic-amd authored and Google-ML-Automation committed Oct 17, 2024
1 parent accf868 commit f3a0fce
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions xla/service/gpu/transforms/command_buffer_scheduling_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ class CommandBufferSchedulingTest : public HloTestBase {
debug_options.set_xla_gpu_graph_min_graph_size(2);
return debug_options;
}

const se::GpuComputeCapability& GetGpuComputeCapability() {
return backend()
.default_stream_executor()
->GetDeviceDescription()
.gpu_compute_capability();
}
};

using CommandBuffer = CommandBufferScheduling::CommandBuffer;
Expand Down Expand Up @@ -809,6 +816,10 @@ TEST_F(CommandBufferSchedulingTest, WhileNotCommand) {
}

TEST_F(CommandBufferSchedulingTest, While) {
const auto& gpu_desc = GetGpuComputeCapability();
if (std::holds_alternative<se::RocmComputeCapability>(gpu_desc)) {
GTEST_SKIP() << "Not supported for ROCm!";
}
const char* hlo = R"(
HloModule TestModule, is_scheduled=true
Expand Down Expand Up @@ -870,6 +881,10 @@ TEST_F(CommandBufferSchedulingTest, While) {
}

TEST_F(CommandBufferSchedulingTest, Conditional) {
const auto& gpu_desc = GetGpuComputeCapability();
if (std::holds_alternative<se::RocmComputeCapability>(gpu_desc)) {
GTEST_SKIP() << "Not supported for ROCm!";
}
const char* hlo = R"(
HloModule TestModule, is_scheduled=true
Expand Down

0 comments on commit f3a0fce

Please sign in to comment.