PR #18062: [ROCm] Fix gemm_rewriter_test for AMD GCN Arch #18533
+9
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_688022433
branch
from
e3934d6
to
fa1fee8
Compare
Imported from GitHub PR #18062 #16841 removes scaling factor constants in gemm_rewriter for FP8 data types. This patch address the same in the gemm_rewriter_test Copybara import of the project: -- be4da5b by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix gemm_rewriter_test for AMD GCN Arch #16841 removes scaling factor constants in gemm_rewriter for FP8 data types. This patch address the same in the gemm_rewriter_test Merging this change closes #18062 COPYBARA_INTEGRATE_REVIEW=#18062 from ROCm:ci_fix_gemm_rewriter_fp8_tests_20241008 be4da5b PiperOrigin-RevId: 688034088
copybara-service
bot
force-pushed
the
test_688022433
branch
from
fa1fee8
to
74cfb8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18062: [ROCm] Fix gemm_rewriter_test for AMD GCN Arch
Imported from GitHub PR #18062
#16841 removes scaling factor constants in gemm_rewriter for FP8 data types. This patch address the same in the gemm_rewriter_test
Copybara import of the project:
--
be4da5b by Harsha HS Harsha.HavanurShamsundara@amd.com:
[ROCm] Fix gemm_rewriter_test for AMD GCN Arch
#16841 removes scaling factor
constants in gemm_rewriter for FP8 data types. This patch address
the same in the gemm_rewriter_test
Merging this change closes #18062
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18062 from ROCm:ci_fix_gemm_rewriter_fp8_tests_20241008 be4da5b