Skip to content

Conversation

@Shreshth3
Copy link
Contributor

This PR allows users to add specific properties in addition to the defaults when using zfs list -o or zpool list -o. For example, zpool list -o +guid will run zpool list showing the default properties in addition to guid.

Resolves #17112.

One note: with the current implementation, if a user tries to append a property that is already in the defaults (e.g. name), they will see that column two times. If this is not acceptable, I can adjust the implementation accordingly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This commit allows users to add specific options in addition
to the defaults when using `zfs list` or `zpool list`. For
example, `zpool list -o +guid` will run `zpool list` showing
the default properties in addition to guid.

Resolves openzfs#17112.

Signed-off-by: Shreshth Srivastava <shreshthsrivastava2@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 19, 2025
@intelfx
Copy link
Contributor

intelfx commented Dec 22, 2025

One note: with the current implementation, if a user tries to append a property that is already in the defaults (e.g. name), they will see that column two times. If this is not acceptable, I can adjust the implementation accordingly.

It would be nice to support this case by removing such a column from the "default" part of the list and inserting it into the "user" part of the list at the specified position. E.g. I might want to keep the mountpoint column last, and so I'd write zfs list -o +lused,lrefer,mountpoint.

Additionally, perhaps some care is needed to support repeated -o +... options; this is a non-intuitive restriction and might create problems when scripting around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow appending to the default ZFS options via + prefix or add a defaults property

3 participants