libunicode: merge into libzpool #18071
Open
+3
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@behlendorf you might recall you suggested that libunicode, libzstd and libicp all get this treatment. The other two aren't this simple mostly because they haven't different compile flags which automake doesn't really provide a good mechanism for outside of utility libraries. I'm intending to look into them further once I finish up the "easy" cleanup (like this one) and get symbol visibility where I want them. |
behlendorf
reviewed
Dec 19, 2025
behlendorf
approved these changes
Dec 20, 2025
behlendorf
added
Status: Accepted
It's a single source file that is not used anywhere else, so there's no reason to keep it separate. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com>
Now that it's built into the main zfs module in all cases, there's no reason to put it in its own dir. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <robn@despairlabs.com>
robn
force-pushed
the
libunicode-delete
branch
from
0ff33bc to
17e1a16
Compare
github-actions
bot
removed
the
Status: Accepted
Member
Author
|
Just rebased to sort out the conflict in the comment in |
Contributor
|
I am a bit torn on these PRs, I get the attraction of cleaning up code, and you are doing the heavy lifting, but it also means I have to go that work you just did, twice.. just for cleanups. Ah well, it is the situation I find myself in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Tiny cleanup of opportunity.
Description
Just build
u8_textprep.cdirectly into libzpool, since nothing else uses it.And then, since it's always built into the zfs "module" in all situations, move it to
module/zfs.How Has This Been Tested?
Compile checked on Linux & FreeBSD.
Types of changes
Checklist:
Signed-off-by.