Skip to content

zcommon, cmd/zfs, man, scripts: cosmetic changes #18079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
intelfx wants to merge 4 commits into
base: master
Choose a base branch
from
Open

zcommon, cmd/zfs, man, scripts: cosmetic changes #18079

intelfx wants to merge 4 commits into from
+7 −6

Conversation

@intelfx
Copy link
Contributor

@intelfx intelfx commented Dec 21, 2025 •
edited
Loading

Motivation and Context

Cosmetic changes made in course of working on other things.

Description

  • fix up comments, string constants, and manpages spelling
  • silence a few (benign) shellcheck errors that slipped through the cracks

How Has This Been Tested?

  • compile-tested on x86_64 Linux

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@intelfx
zvol: cosmetic: fix up volthreading property short name
35fa219 
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx
zfs_main: cosmetic: add missing flag to the comment for create
55b24bb 
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx
man: cosmetic: fix typos; use consistent spelling for "non-existing"
d1ba25f 
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx intelfx changed the title zcommon, zfs(8), man: cosmetic changes zcommon, cmd/zfs, man: cosmetic changes Dec 21, 2025
@intelfx intelfx marked this pull request as draft December 21, 2025 17:40
@github-actions github-actions bot added the Status: Work in Progress Not yet ready for general review label Dec 21, 2025
@intelfx intelfx marked this pull request as ready for review December 21, 2025 17:40
@github-actions github-actions bot added Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Dec 21, 2025
@intelfx
zed.d, contrib: fix shellcheck errors in scripts
2da4dfd 
Not sure why this was not caught by CI; perhaps my shellcheck is new
enough to catch more things.

Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx intelfx changed the title zcommon, cmd/zfs, man: cosmetic changes zcommon, cmd/zfs, man, scripts: cosmetic changes Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amotin amotin amotin approved these changes

Assignees

No one assigned

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@intelfx @amotin