Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 80.39% 80.19% -0.21%
==========================================
Files 47 47
Lines 1974 2065 +91
Branches 192 205 +13
==========================================
+ Hits 1587 1656 +69
- Misses 334 353 +19
- Partials 53 56 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds functionality to move, recover and delete books from the API/UI.



Changes
get_book_or_nonefunction to allow for passing params for filtering instead of havingif...elsechecks for attributesdelete_fileslogic set the bookhas_errorif deletion failed. This doesn't seem correct as the book does not necessarily have an error. Instead, in addition to logging the exception message, set theneeds_file_operationto Falsehas_errorflag from filters to get_next_book_to_delete as we want to now delete books that have errors tooquarantine,stagingand/orprodbooks in library.xml generation (filter added in DB queryget_latest_books_for_collection)This closes #143