Fix multiple unit tests

openzim · Jul 24, 2023 · faec531 · faec531
1 parent 847ec8a
commit faec531
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/test/e2e/bm.e2e.test.ts b/test/e2e/bm.e2e.test.ts
@@ -28,16 +28,16 @@ describe('bm', () => {
     // Created 1 output
     expect(outFiles).toHaveLength(1)
 
-    /* for (const dump of outFiles) {
+    for (const dump of outFiles) {
       if (dump.nopic) {
         // nopic has enough files
-        expect(dump.status.files.success).toBeGreaterThan(15)
+        expect(dump.status.files.success).toBeGreaterThan(14)
         // nopic has enough redirects
         expect(dump.status.redirects.written).toBeGreaterThan(170)
         // nopic has enough articles
         expect(dump.status.articles.success).toBeGreaterThan(700)
       }
-    }*/
+    }
 
     if (await zimcheckAvailable()) {
       await expect(zimcheck(outFiles[0].outFile)).resolves.not.toThrowError()

diff --git a/test/e2e/en10.e2e.test.ts b/test/e2e/en10.e2e.test.ts
@@ -34,7 +34,7 @@ describe('en10', () => {
     for (const dump of outFiles) {
       if (dump.nopic) {
         // nopic has enough files
-        // expect(dump.status.files.success).toBeGreaterThan(17)
+        expect(dump.status.files.success).toBeGreaterThan(16)
         expect(dump.status.files.success).toBeLessThan(25)
         // nopic has enough redirects
         expect(dump.status.redirects.written).toBeGreaterThan(480)

diff --git a/test/unit/mwApi.test.ts b/test/unit/mwApi.test.ts
@@ -30,7 +30,7 @@ describe('mwApi', () => {
     await mw.getNamespaces([], downloader)
   })
 
-  /* test('MWApi Article Ids', async () => {
+  test('MWApi Article Ids', async () => {
     const aIds = ['London', 'United_Kingdom', 'Farnborough/Aldershot_built-up_area']
     await getArticleIds(downloader, redisStore, mw, 'Main_Page', aIds)
     const articlesById = await redisStore.articleDetailXId.getMany(aIds)
@@ -40,7 +40,7 @@ describe('mwApi', () => {
     expect(United_Kingdom).toBeDefined()
 
     // Article "United_Kingdom" has categories
-    expect(United_Kingdom?.categories?.length).toBeGreaterThanOrEqual(12)
+    expect(United_Kingdom?.categories?.length).toBeGreaterThanOrEqual(11)
 
     // Article "United_Kingdom" has thumbnail
     expect(United_Kingdom).toHaveProperty('thumbnail')
@@ -56,7 +56,7 @@ describe('mwApi', () => {
 
     // Complex article was scraped
     expect(articlesById).toHaveProperty('Farnborough/Aldershot_built-up_area')
-  })*/
+  })
 
   test('MWApi NS', async () => {
     await getArticlesByNS(0, downloader, redisStore, undefined, 5) // Get 5 continues/pages of NSes

diff --git a/test/unit/saveArticles.test.ts b/test/unit/saveArticles.test.ts
@@ -62,7 +62,6 @@ describe('saveArticles', () => {
   })
 
   describe('applyOtherTreatments', () => {
-    /*
     let dump: Dump
     let dump2: Dump
     let articleHtml: string
@@ -82,6 +81,7 @@ describe('saveArticles', () => {
       dump2 = new Dump('', { keepEmptyParagraphs: true } as any, dump.mwMetaData)
     })
 
+    /*
     test('Found no empty details elements when they should be stripped in mobile view', async () => {
       const doc = domino.createDocument(articleHtml)
       await applyOtherTreatments(doc, dump)
@@ -110,8 +110,13 @@ describe('saveArticles', () => {
       }
       expect(fewestChildren).toBeLessThanOrEqual(1)
     })
+    */
 
-    test('Found empty sections when they should be left im desktop view', async () => {
+    /*
+      TODO: Investigate empty section behavior for other endpoints such as page/html and page/mobile html
+      then rewrite the test below
+    /
+    /* test('Found empty sections when they should be left im desktop view', async () => {
       const doc = domino.createDocument(articleHtml)
       await applyOtherTreatments(doc, dump2)