Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "parsoid" in query string to retrieve CSS/JS dependencies #1846

Closed
wants to merge 2 commits into from

Conversation

cscott
Copy link
Contributor

@cscott cscott commented May 21, 2023

  • Keep API type alongside API URL so we can properly label download results
  • Add new 'UseParsoid' API type, and prefer it over MCS API

@stale
Copy link

stale bot commented May 28, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label May 28, 2023
@kelson42 kelson42 changed the title use parsoid Use "parsoid" in query string to retrieve CSS/JS dependencies Jul 18, 2023
@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF Please review and polish once basic rearchitecture of API end-point mgmt is over (mostly PRs #1854 and #1839)

@kelson42 kelson42 added this to the 2.0.0 milestone Jul 18, 2023
@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF Do we agree to review/fix this after #1839? Or do we have another blocker?

@stale stale bot removed the stale label Jul 28, 2023
@VadimKovalenkoSNF
Copy link
Collaborator

Do we agree to review/fix this after #1839?
@kelson42 Yes, I'd like 1839 and 1854 to be done first.

@kelson42
Copy link
Collaborator

@VadimKovalenkoSNF The blockers tickets are closed meanwhile

@kelson42 kelson42 modified the milestones: 2.0.0, 1.14.0 Aug 28, 2023
@kelson42
Copy link
Collaborator

kelson42 commented Sep 6, 2023

Waiting feedback of @cscott for https://phabricator.wikimedia.org/T324866#9139172

@VadimKovalenkoSNF
Copy link
Collaborator

The functionality of this PR has been moved here - #1899

@kelson42 kelson42 closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants