-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Codecov configuration #1870
Conversation
threshold: 0.1% | ||
patch: false | ||
changes: false | ||
threshold: 1% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increasing the threshold is a workaround for me. Please take a look at my comment here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitly, it's just a configuration which has proven to work for an other repository. It seems to me more appropriate, but it does not fix the problem/questioning we have with #1865
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 69.73% 70.51% +0.77%
==========================================
Files 24 23 -1
Lines 2647 2598 -49
Branches 601 597 -4
==========================================
- Hits 1846 1832 -14
+ Misses 690 655 -35
Partials 111 111 ☔ View full report in Codecov by Sentry. |
threshold: 1% | ||
patch: | ||
default: | ||
target: 90% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90% looks pretty strict to me. We can use this value for now and see how it will affect MCS decommission and other changes related to migration/updation things.
No description provided.