Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Codecov configuration #1870

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Improve Codecov configuration #1870

merged 1 commit into from
Aug 1, 2023

Conversation

kelson42
Copy link
Collaborator

No description provided.

@kelson42 kelson42 marked this pull request as ready for review July 28, 2023 19:15
threshold: 0.1%
patch: false
changes: false
threshold: 1%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the threshold is a workaround for me. Please take a look at my comment here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitly, it's just a configuration which has proven to work for an other repository. It seems to me more appropriate, but it does not fix the problem/questioning we have with #1865

@kelson42 kelson42 changed the title Codecov Improve Codecov configuration Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.77% 🎉

Comparison is base (e99aa3a) 69.73% compared to head (a1c0e00) 70.51%.
Report is 5 commits behind head on main.

❗ Current head a1c0e00 differs from pull request most recent head 0e0e577. Consider uploading reports for the commit 0e0e577 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   69.73%   70.51%   +0.77%     
==========================================
  Files          24       23       -1     
  Lines        2647     2598      -49     
  Branches      601      597       -4     
==========================================
- Hits         1846     1832      -14     
+ Misses        690      655      -35     
  Partials      111      111              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

threshold: 1%
patch:
default:
target: 90%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% looks pretty strict to me. We can use this value for now and see how it will affect MCS decommission and other changes related to migration/updation things.

@kelson42 kelson42 merged commit 82ac61e into main Aug 1, 2023
3 checks passed
@kelson42 kelson42 deleted the codecov branch August 1, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants