Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md - local install and local redis #1914

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxslug
Copy link

@maxslug maxslug commented Sep 21, 2023

Updated instructions w/ Local Redis install too.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 1, 2023

I don't really understand what this README brings more. Part of it is no realated to MWoffliner (nvm, redis), part of it is already in the README.

@kelson42 kelson42 self-requested a review October 1, 2023 18:39
@maxslug
Copy link
Author

maxslug commented Oct 2, 2023

It gives instructions on how to install as non-root, especially when you can't upgrade the system version of node js. For us that don't program javascript, having easy to follow directions is never a bad thing.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (77bb173) to head (b828093).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1914      +/-   ##
==========================================
- Coverage   74.46%   72.08%   -2.39%     
==========================================
  Files          41       41              
  Lines        3145     3145              
  Branches      688      688              
==========================================
- Hits         2342     2267      -75     
- Misses        683      744      +61     
- Partials      120      134      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants