Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test timeout to avoid flakiness #2045

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Increase test timeout to avoid flakiness #2045

merged 1 commit into from
Jun 23, 2024

Conversation

audiodude
Copy link
Member

We were getting the following in CI:

FAIL test/unit/mwApiCapabilities.test.ts (10.2 s)
  ● Checking Mediawiki capabilities › test capabilities of pokemon.fandom.com with RestApi receipt

    thrown: "Exceeded timeout of 5000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      67 |   })
      68 |
    > 69 |   test('test capabilities of pokemon.fandom.com with RestApi receipt', async () => {
         |   ^
      70 |     MediaWiki.base = 'https://pokemon.fandom.com/'
      71 |     MediaWiki.wikiPath = '/'
      72 |     MediaWiki.restApiPath = 'rest.php'

      at test/unit/mwApiCapabilities.test.ts:69:3
      at test/unit/mwApiCapabilities.test.ts:3:1

Some of the tests have timeouts of up to 60s, so it seems reasonable to increase this timeout to 30s

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.72%. Comparing base (e940d85) to head (d8cf9ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2045   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files          41       41           
  Lines        3141     3141           
  Branches      688      688           
=======================================
  Hits         2347     2347           
  Misses        675      675           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 7f61953 into main Jun 23, 2024
6 checks passed
@kelson42 kelson42 deleted the flaky-test branch June 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants