Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wiki href as proper Referer header #2068

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Use wiki href as proper Referer header #2068

merged 1 commit into from
Jul 23, 2024

Conversation

audiodude
Copy link
Member

Fixes #2067.

We use the base URL of the wiki being scraped as the Referer. This should work for all WMF wikis.

@audiodude audiodude requested a review from kelson42 July 23, 2024 19:00
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.45%. Comparing base (acedee6) to head (6b631b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
+ Coverage   74.36%   74.45%   +0.09%     
==========================================
  Files          41       41              
  Lines        3144     3144              
  Branches      688      688              
==========================================
+ Hits         2338     2341       +3     
+ Misses        685      683       -2     
+ Partials      121      120       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 6a78f41 into main Jul 23, 2024
6 checks passed
@kelson42 kelson42 deleted the fix-referer branch July 23, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use scraped site as referrer rather than a "hack"
2 participants