Unset metadata_from + rollback to Python 3.10
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
changed the title
metadata_from + remove unused noqa
benoit74
force-pushed
the
remove_unused_metadata
branch
from
1e74b41
to
970dded
Compare
benoit74
force-pushed
the
remove_unused_metadata
branch
from
b599959
to
e92bcc0
Compare
benoit74
force-pushed
the
remove_unused_metadata
branch
from
e92bcc0
to
bd67bbb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=====================================
Coverage 1.83% 1.83%
=====================================
Files 10 10
Lines 928 928
Branches 164 147 -17
=====================================
Hits 17 17
Misses 911 911 ☔ View full report in Codecov by Sentry. |
|
I propose to ignore codecov warning, since the file is not covered at all anyway. |
benoit74
changed the title
metadata_from + remove unused noqametadata_from + rollback to Python 3.10
|
I just fixed the PR title which was wrong indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
mainstatus since this would solve urllib3 versions are conflicting #184 (which is blocking all scrapers) but:metadata_fromwhen running the scraper withyoutube2zim-playlists; it is obviously harmless to simply disable this code since it is not possible to setup themetadata_fromwhich current code anywaymainis in fact not correct, it is using Python 3.11 while we are still atzimscraperlib2.0 which supports only Python 3.10 (don't know why this is not causing a problem in Docker build + why it does not raised a red flag before)Changes
metadata_fromto always beNonefor nowzimscraperlibversion constraints in hatch dependencies with project version (just in case)