Add Video player page #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Two small inline comments.
Regarding WebP support, I unfortunately cannot test it on my machines. And I'm not even sure I should. I've opened openzim/overview#36 to discuss this topic openly, because I begin to consider we might be loosing our precious time with this WebP / WebM polyfills.
dan-niles
force-pushed
the
video-player-page
branch
from
4b998e7
to
660c332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the video player for the new UI.
channel_descriptionandchannel_joined_dateto theAuthorschema so that we can display channel information easily in the video player page.webp-herofor WebP support in unsupported browsers.Note:ogv.js has not been setup yet. I've created #230 to track it seperately.Closes #215
Closes #174