Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title in index.html to be ZIM title #250

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix title in index.html to be ZIM title #250

merged 1 commit into from
Jul 1, 2024

Conversation

dan-niles
Copy link
Collaborator

Fix #227

Replace the <title> tag (using RegEx) in index.html of new Vue.js UI to be the ZIM title.

@dan-niles dan-niles self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 1.61%. Comparing base (0df7426) to head (82d6fa9).

Files Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #250      +/-   ##
========================================
- Coverage   1.62%   1.61%   -0.01%     
========================================
  Files         11      11              
  Lines       1047    1052       +5     
  Branches     158     159       +1     
========================================
  Hits          17      17              
- Misses      1030    1035       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review June 28, 2024 09:03
@dan-niles dan-niles requested a review from benoit74 June 28, 2024 09:03
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 29fa65c into main Jul 1, 2024
8 of 9 checks passed
@benoit74 benoit74 deleted the fix-zim-title branch July 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New UI: HTML page title should be the ZIM title
2 participants