Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display playlist panel for videos played from homepage #251

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

dan-niles
Copy link
Collaborator

Close #241

Modified VideoGrid and VideoCard components to accept a playlistSlug prop, so that the playlist panel can be displayed whenever videos from the homepage are played.

@dan-niles dan-niles self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.62%. Comparing base (6689f98) to head (cbc2633).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #251   +/-   ##
=====================================
  Coverage   1.62%   1.62%           
=====================================
  Files         11      11           
  Lines       1047    1047           
  Branches     158     158           
=====================================
  Hits          17      17           
  Misses      1030    1030           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review June 28, 2024 09:25
@dan-niles dan-niles requested a review from benoit74 June 28, 2024 09:26
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will take care of rebase + merge

@benoit74 benoit74 merged commit 6cd1699 into main Jul 1, 2024
9 checks passed
@benoit74 benoit74 deleted the homepage-playlist-panel branch July 1, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show playlist panel instead of arrows for videos from the Videos tab
2 participants