Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix side margins on tablet screens in zimui #255

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

dan-niles
Copy link
Collaborator

Changes:

  • Fix side margins on tablet screens so that the content fills the entire screen.
  • Modify playlist panel height calculation so that the panel fits screen vertically.

Before:
image

After:
image

Fix #252

@dan-niles dan-niles self-assigned this Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.62%. Comparing base (a34f5e8) to head (ba57d50).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #255   +/-   ##
=====================================
  Coverage   1.62%   1.62%           
=====================================
  Files         11      11           
  Lines       1047    1047           
  Branches     158     158           
=====================================
  Hits          17      17           
  Misses      1030    1030           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-niles dan-niles marked this pull request as ready for review July 1, 2024 09:10
@dan-niles dan-niles requested a review from benoit74 July 1, 2024 09:11
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested in real conditions, but it looks coherent, so LGTM, I assume you tested it significantly at various resolutions

We will need anyway a throughout review of look and feel at various screen sizes once new UI is ready.

@benoit74 benoit74 merged commit 6689f98 into main Jul 1, 2024
9 checks passed
@benoit74 benoit74 deleted the fix-tablet-margin branch July 1, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New UI: Remove side margins in UI for tablet screens
2 participants