Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty playlists #341

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Ignore empty playlists #341

merged 1 commit into from
Sep 24, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #340

@benoit74 benoit74 self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 1.52%. Comparing base (0b9bed5) to head (b8f83e4).

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #341      +/-   ##
========================================
- Coverage   1.52%   1.52%   -0.01%     
========================================
  Files         11      11              
  Lines       1112    1118       +6     
  Branches     166     168       +2     
========================================
  Hits          17      17              
- Misses      1095    1101       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixes the ticket. Is the case of only empty playlists (ie no videos at all) handled?

@benoit74
Copy link
Collaborator Author

Open #347 to answer your point, interesting 🤣

@benoit74 benoit74 merged commit dfcf7ae into main Sep 24, 2024
10 checks passed
@benoit74 benoit74 deleted the empty_playlist branch September 24, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scraper is failing on empty playlist
2 participants