Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper ZIM metadata key for Scraper and Tags #370

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Use proper ZIM metadata key for Scraper and Tags #370

merged 1 commit into from
Oct 21, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 21, 2024

Fix #369

Changes:

  • I've also enhanced a bit the integration tests for better checks (even if we can see that we already had a test about scraper metadata instead of Scraper, so it will not solve the problem we had in this issue at all)

@benoit74 benoit74 self-assigned this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.50%. Comparing base (f20ac6d) to head (e19ce5b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #370   +/-   ##
=====================================
  Coverage   1.50%   1.50%           
=====================================
  Files         11      11           
  Lines       1132    1132           
  Branches     171     171           
=====================================
  Hits          17      17           
  Misses      1115    1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review October 21, 2024 12:49
@benoit74 benoit74 requested a review from rgaudin October 21, 2024 12:51
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benoit74 benoit74 merged commit 160ec2c into main Oct 21, 2024
10 checks passed
@benoit74 benoit74 deleted the fix_tags branch October 21, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REGRESSION] Tags and Scraper metadata is incorrectly populated
2 participants