Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing playsinline attribute for proper operation on iOS #374

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #368

@benoit74 benoit74 self-assigned this Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.25%. Comparing base (95ad5bc) to head (47162b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #374   +/-   ##
=====================================
  Coverage   1.25%   1.25%           
=====================================
  Files         11      11           
  Lines       1114    1114           
  Branches     163     163           
=====================================
  Hits          14      14           
  Misses      1100    1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 requested a review from rgaudin October 31, 2024 16:14
@benoit74 benoit74 marked this pull request as ready for review October 31, 2024 16:14
Base automatically changed from format_simplified to main November 1, 2024 13:26
@benoit74 benoit74 merged commit 61727d8 into main Nov 1, 2024
10 checks passed
@benoit74 benoit74 deleted the playsinline branch November 1, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add playsinline to videoJS for proper operation on apple
2 participants