Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few things in workflows #436

Merged
merged 5 commits into from
Dec 21, 2024
Merged

Fix a few things in workflows #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2304d60
Deprecate set-output
kelson42 Dec 21, 2024
c1deeb1
Remove deprecated macos-12 workflow
kelson42 Dec 21, 2024
6f9af23
Bump-up to actions/upload-artifact@v4
kelson42 Dec 21, 2024
e8e51e3
Remove useless HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1
kelson42 Dec 21, 2024
93cb165
Stop compiling in debug for Windows
kelson42 Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
fail-fast: false
matrix:
os:
- macos-12
- macos-13
runs-on: ${{ matrix.os }}

Expand All @@ -32,10 +31,8 @@ jobs:
# upgrade from python@3.12 to python@3.12.2 fails to overwrite those
rm -f /usr/local/bin/2to3 /usr/local/bin/2to3-3.12 /usr/local/bin/idle3 /usr/local/bin/idle3.12 /usr/local/bin/pydoc3 /usr/local/bin/pydoc3.12 /usr/local/bin/python3 /usr/local/bin/python3-config /usr/local/bin/python3.12 /usr/local/bin/python3.12-config
brew install gcovr ninja libmagic
env:
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1

- name: Install python modules
- name: Install Python modules
run: pip3 install meson==0.49.2 pytest

- name: Install dependencies
Expand Down Expand Up @@ -86,7 +83,7 @@ jobs:
run: |
set PKG_CONFIG_PATH=%cd%\BUILD_win-amd64\INSTALL\lib\pkgconfig
set CPPFLAGS=-I%cd%\BUILD_win-amd64\INSTALL\include
meson.exe setup . build -Dstatic-linkage=true --buildtype=debug
meson.exe setup . build -Dstatic-linkage=true --buildtype=release
cd build
ninja.exe

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ jobs:
run: |
if [[ $REF == refs/tags* ]]
then
echo "::set-output name=ppa::kiwixteam/release"
echo "ppa=kiwixteam/release" >> $GITHUB_OUTPUT
else
echo "::set-output name=ppa::kiwixteam/dev"
echo "ppa=kiwixteam/dev" >> $GITHUB_OUTPUT
fi
env:
REF: ${{ github.ref }}
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
args: --no-sign
ppa: ${{ steps.ppa.outputs.ppa }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: Packages for ${{ matrix.distro }}
path: output
Expand Down