-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break everything and introduce i18n #69
Conversation
04a31a1
to
76e4d25
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something! Thank you.
I tested it and it seems to work fine. I was somehow surprised that the UI looks the same 😀
On the python side, I think there are a couple of place with poor type hints (zimfarm module?).
On the Vue part, I mostly skimmed through the code but it looks good and coherent.
On personal taste, I find the user feedback too dim. If there is an error in making a request, theres just a light toast at the bottom of the page that disappears after 5s.
I had to make several requests to see it.
Mostly 🤫
Fixed, thank you
OK, thank you
I think you refer to home page issue, when it fails to fetch offliner definition. This is indeed something I forgot about. I changed the toast to red + I added a message in red as well which stays forever. On the page about the task status, there is a red message when we fail to fetch the task. |
0117b97
to
5d66daf
Compare
- Introduce i18n of the UI and the emails - Move ui to Vue 3, Vuetify, Pinia, Vue-Router - Move api to FastAPI, hatch - Fix many small glitches linked to recent Zimfarm changes - Enhance some messages
5d66daf
to
648edb1
Compare
(merging because confirmed with rgaudin that further review is not necessary once conversations are taken care of) |
Code work for #46 and #53 ; translation will then have to be setup on translatewiki
Rationale
Nota: