Unit test for null endpoint serviceName

openzipkin · Sep 13, 2019 · 3ae00c7 · 3ae00c7
1 parent 48777fb
commit 3ae00c7
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/...on-stackdriver/src/test/java/zipkin2/translation/stackdriver/AttributesExtractorTest.java b/...on-stackdriver/src/test/java/zipkin2/translation/stackdriver/AttributesExtractorTest.java
@@ -148,6 +148,25 @@ public void testEndpointIsSetIpv6() {
     assertThat(clientLabels).doesNotContainKeys("endpoint.ipv4", "endpoint.ipv6");
   }
 
+  @Test
+  public void testEndpointWithNullServiceName() {
+    Endpoint.Builder serverEndpointBuilder = Endpoint.newBuilder().port(80);
+    Endpoint serverEndpoint = serverEndpointBuilder.build();
+    assertThat(serverEndpoint.serviceName()).isNull();
+    Span serverSpan =
+        Span.newBuilder()
+            .kind(Kind.SERVER)
+            .traceId("4")
+            .name("test-span")
+            .id("5")
+            .localEndpoint(serverEndpoint)
+            .build();
+
+    AttributesExtractor extractor = new AttributesExtractor(Collections.emptyMap());
+    Map<String, AttributeValue> serverLabels = extractor.extract(serverSpan).getAttributeMapMap();
+    assertThat(serverLabels).doesNotContainKey("endpoint.serviceName");
+  }
+
   @Test
   public void testComponentLabelIsSet() {
     AttributesExtractor extractor = new AttributesExtractor(Collections.emptyMap());