Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update netty from 4.1.78.Final to 4.1.95.Final #3548

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

darkmastermindz
Copy link
Contributor

Bump netty version to 4.1.92.Final to match Spring Boot v2.7.12
Remediates CVE-2022-41881
Ref issue: #3512

Bump to match Spring Boot v2.7.12
Remediates CVE-2022-41881 
Ref issue: openzipkin#3512
@shakuzen
Copy link
Member

shakuzen commented Jun 9, 2023

The test failure looks unrelated to this change. We should fix that test first.

@darkmastermindz darkmastermindz changed the title chore(deps): Update netty from 4.1.78.Final to 4.1.92.Final chore(deps): Update netty to 4.1.92.Final Jun 9, 2023
@darkmastermindz darkmastermindz changed the title chore(deps): Update netty to 4.1.92.Final chore(deps): Update netty from 4.1.78.Final to 4.1.92.Final Jun 9, 2023
@darkmastermindz
Copy link
Contributor Author

The test failure looks unrelated to this change. We should fix that test first.

@shakuzen Not quite sure what this is related to and how to fix. Looks like the CI is failing to execute the docker build?

#14 1.659 ERROR: unable to select packages:
[81](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:82)
#14 1.661   mysql-10.11.4-r0:
[82](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:83)
#14 1.661     breaks: world[mysql~10.11.3]
[83](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:84)
#14 1.662   mysql-client-10.11.4-r0:
[84](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:85)
#14 1.662     breaks: world[mysql-client~10.11.3]
[85](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:86)
#14 ERROR: executor failed running [/bin/sh -c (cd install && ./install.sh) && rm -rf ./install]: exit code: 2
[86](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:87)
------
[87](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:88)
 > [zipkin-mysql 6/7] RUN (cd install && ./install.sh) && rm -rf ./install:

@darkmastermindz
Copy link
Contributor Author

@jcchavezs @llinder @shakuzen Could you help with fixing this failing test?

@darkmastermindz darkmastermindz changed the title chore(deps): Update netty from 4.1.78.Final to 4.1.92.Final chore(deps): Update netty from 4.1.78.Final to 4.1.95.Final Jul 23, 2023
@darkmastermindz
Copy link
Contributor Author

Bumping again because of new CVE. Also bumped Spring to match.

@darkmastermindz
Copy link
Contributor Author

Hi, @llinder @shakuzen Can this be merged? I do see tests was successful https://github.com/openzipkin/zipkin/actions/runs/5633888570

@llinder
Copy link
Member

llinder commented Aug 1, 2023

I will see if I can fix the python package issue in another PR and if successful we can merge this one.

@llinder
Copy link
Member

llinder commented Aug 1, 2023

pip cqlsh install issues resolved in this PR #3554

Thanks for submitting the Netty fix @darkmastermindz!

@llinder llinder merged commit 56a88df into openzipkin:master Aug 1, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants