Enhance the query performance and storage size of the Cassandra storage in v3 server #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrproliu
commented
Nov 7, 2023
mrproliu
commented
- Improve collect throughput: Change the synchronous writing of batch data synchronization to asynchronous writing.
- Reducing Unnecessary Fields: Reduce unnecessary field storage to reduce storage space usage.
- Query Optimization: Split the original query method into multiple files, so that each query can be optimized better.
wu-sheng
reviewed
Nov 7, 2023
| final String columnName = model.getColumns().get(i).getColumnName().getStorageName(); | ||
| if (StorageData.TIME_BUCKET.equals(columnName) || | ||
| ZipkinSpanRecord.TIMESTAMP_MILLIS.equals(columnName) || | ||
| JDBCTableInstaller.TABLE_COLUMN.equals(columnName)) { |
There was a problem hiding this comment.
CassandraTableInstaller is referring to the JDBC implementation? Where does this TABLE COLUMN come from?
There was a problem hiding this comment.
CassandraTableInstaller is referring to the JDBC implementation?
Nope, For now, the table installer only caches the table metadata.
Where does this TABLE COLUMN come from?
There are definitions in skywalking core that are not necessary for the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.