Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lens: fixes BASE_PATH handling and re-aligns to old resource paths #3722

Merged
merged 1 commit into from
Feb 12, 2024
Merged

lens: fixes BASE_PATH handling and re-aligns to old resource paths #3722

merged 1 commit into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. lens: fixes BASE_PATH handling and re-aligns to old resource paths 

    The last commit moved things forward, but it broke how we used the
BASE_PATH variable. This reverts to the old logic and fixes up the
build so it behaved like the last one.

Along the way, I discovered some tests were disabled, and as able to
fix them except one that I need @anuraaga or similar's help on.

@SamTV12345 as a matter of some urgency, once this PR is merged, can you
follow-up and test i18n? I noticed the language toggle doesn't work, as
it just is always english.

Signed-off-by: Adrian Cole <adrian@tetrate.io>
    Adrian Cole committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    07eb579 View commit details
    Browse the repository at this point in the history