grpc: enables collector by default #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <adrian@tetrate.io>
| long encodedLength = responseBody.readInt() & 0xffffffffL; | ||
|
|
||
| return ReportResponse.ADAPTER.decode(responseBody); | ||
| void callReport(ListOfSpans spans) throws IOException { |
There was a problem hiding this comment.
I refactored this to close resources.. only other change is verifying the encodedLength is the same as the input. Since the result has no fields, I changed to void return
reta
approved these changes
Feb 20, 2024
anuraaga
reviewed
Feb 20, 2024
zipkin-server/src/test/java/zipkin2/server/internal/ITZipkinGrpcCollector.java
Outdated
Show resolved
Hide resolved
added 2 commits
February 21, 2024 08:22
Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc service hasn't had any requests for change since introduction, and the code in armeria is stable. This enables the gRPC service by default (on both slim and normal builds as it only needs armeria).
This moves it out of experimental (something I neglected to do in 3.0, but better late than never).
cc @openzipkin/armeria