updates depedencies to latest versions, notably fixing Eureka #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Eureka status page registration while updating all depedencies to the latest versions. The most needed update was to armeria 1.27.2. Signed-off-by: Adrian Cole <adrian@tetrate.io>
| @@ -41,7 +41,7 @@ | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>${armeria.groupId}</groupId> | |||
| <groupId>com.linecorp.armeria</groupId> | |||
There was a problem hiding this comment.
I removed the overriding of the group ID as jitpack has been out of commission a while for things we compile
|
|
||
| // Make sure URLs are fully resolved. Notably, the status page URL defaults to the /info | ||
| // endpoint, as that's the one chosen in spring-cloud-netflix. | ||
| assertThat(readString(json, "$.application.instance[0].homePageUrl")) |
There was a problem hiding this comment.
missing eureka registration json tests!
anuraaga
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Eureka status page registration while updating all depedencies to the latest versions. The most needed update was to armeria 1.27.2.
Thanks @openzipkin/armeria for all the upstream (like normal upstream, not mesh definition of that word) help!
