license: removes copyright year and uses SPDX ID #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
commented
Mar 5, 2024
| @@ -23,7 +23,8 @@ jobs: | |||
| # Prevent use of implicit GitHub Actions read-only GITHUB_TOKEN | |||
| # because javadoc_to_gh_pages pushes commits to the gh-pages branch. | |||
| token: ${{ secrets.GH_TOKEN }} | |||
| # allow build-bin/javadoc_to_gh_pages to get the full history | |||
| # Allow build-bin/javadoc_to_gh_pages to fetch and push gh-pages | |||
| # See https://github.com/actions/checkout/issues/578 | |||
There was a problem hiding this comment.
notable thing is the comment was imprecise
anuraaga
approved these changes
Mar 5, 2024
added 2 commits
March 5, 2024 16:55
As a small project, we have to conserve resources and not sign up for work that isn't required. I've recently realized many [commercial](https://github.com/hashicorp/consul/blob/main/command/cli/cli.go#L1-L2) and/or [CNCF projects](https://github.com/open-telemetry/opentelemetry-java/blob/main/api/all/src/main/java/io/opentelemetry/api/trace/Tracer.java#L1-L4) both use SPDX IDs and also don't bother with copyright year. If their legal team is ok with this, surely a volunteer team without access to one should be, too! Doing so accomplishes the following, all of which help volunteers: * significantly increases readability of files, particularly small ones * removes beginning of year maintenance, which cause a lot of FUD last year. IIRC some deployment failed and hours were spent in spite of docs. * eliminates the need to do a full source check out, just to satisfy the license plugin. This means we can use actions/checkout defaults. Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
one nice side effect is the raw HTML isn't dominated by license text anymore ;) $ curl -s localhost:9411/zipkin/index.html
<!--
Copyright The OpenZipkin Authors
SPDX-License-Identifier: Apache-2.0
-->
<!DOCTYPE html>
<html>
<head>
<base href="/zipkin" >
<meta charset="utf-8" />
<link rel="icon" href="/zipkin/favicon.ico" />
<title>Zipkin</title>
<script type="module" crossorigin src="/zipkin/static/js/index.51c4d5b0.js"></script>
<link rel="stylesheet" href="/zipkin/static/css/index.a7aa86b4.css">
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
</body>
</html> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a small project, we have to conserve resources and not sign up for work that isn't required. I've recently realized many commercial and/or CNCF projects both use SPDX IDs and also don't bother with copyright year. If their legal team is ok with this, surely a volunteer team without access to one should be, too!
Doing so accomplishes the following, all of which help volunteers:
(same change as openzipkin/zipkin-reporter-java#257)