Better way to do it without breaking existing

openzipkin · Jul 27, 2018 · 2b1d10e · 2b1d10e
1 parent 74fd55f
commit 2b1d10e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Examples/aspnetcore/frontend/Startup.cs b/Examples/aspnetcore/frontend/Startup.cs
@@ -13,7 +13,7 @@ public class Startup : CommonStartup
         public override void ConfigureServices(IServiceCollection services)
         {
             services.AddHttpClient("Tracer").AddHttpMessageHandler(provider =>
-                new TracingHandler(provider.GetService<IConfiguration>()["applicationName"]));
+                TracingHandler.WithoutInnerHandler(provider.GetService<IConfiguration>()["applicationName"]));
         }
 
         protected override void Run(IApplicationBuilder app, IConfiguration config)

diff --git a/Src/zipkin4net/Src/Transport/Http/TracingHandler.cs b/Src/zipkin4net/Src/Transport/Http/TracingHandler.cs
@@ -12,13 +12,13 @@ public class TracingHandler : DelegatingHandler
         private readonly string _serviceName;
         private readonly Func<HttpRequestMessage, string> _getClientTraceRpc;
 
-        public TracingHandler(string serviceName, HttpMessageHandler httpMessageHandler, Func<HttpRequestMessage, string> getClientTraceRpc = null)
-        : this(Propagations.B3String.Injector<HttpHeaders>((carrier, key, value) => carrier.Add(key, value)), serviceName, httpMessageHandler, getClientTraceRpc)
+        public TracingHandler(string serviceName, HttpMessageHandler httpMessageHandler = null, Func<HttpRequestMessage, string> getClientTraceRpc = null)
+        : this(Propagations.B3String.Injector<HttpHeaders>((carrier, key, value) => carrier.Add(key, value)), serviceName, httpMessageHandler ?? new HttpClientHandler(), getClientTraceRpc)
         { }
 
-        public TracingHandler(string serviceName, Func<HttpRequestMessage, string> getClientTraceRpc = null)
-            : this(Propagations.B3String.Injector<HttpHeaders>((carrier, key, value) => carrier.Add(key, value)), serviceName, getClientTraceRpc)
-        { }
+
+        public static TracingHandler WithoutInnerHandler(string serviceName, Func<HttpRequestMessage, string> getClientTraceRpc = null)
+         =>  new TracingHandler(Propagations.B3String.Injector<HttpHeaders>((carrier, key, value) => carrier.Add(key, value)), serviceName, getClientTraceRpc);
 
         private TracingHandler(IInjector<HttpHeaders> injector, string serviceName, HttpMessageHandler httpMessageHandler, Func<HttpRequestMessage, string> getClientTraceRpc = null)
             : base(httpMessageHandler)