Allow enrollmentJwt from secret (ziti-router-chart) #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrkourier
changed the base branch from
main
to
jan94_feature-allowEnrollmentJwtFromSecret
qrkourier
merged commit 6cd6472
into
openziti:jan94_feature-allowEnrollmentJwtFromSecret
1 check passed
|
You are welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @qrkourier,
Currently, the only way to specify the enrollmentJwt is by setting the
enrollmentJwtproperty in the values for the ziti-router chart. This approach can be cumbersome when automating the deployment process of Ziti controllers and routers, as the enrollmentJwt must be actively acquired from the Ziti controller by calling its API.Proposal:
I propose allowing the specification of a secret name (for a secret which could be created before the actual Ziti router deployment) that holds the enrollmentJwt. This way, an automated process can interact with the Ziti controller API to create the secret in the respective Kubernetes namespace before triggering the router deployment.
Benefits:
This enhancement would significantly improve my deployment procedures and likely benefit others facing similar challenges.
BR
Jan