Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize enrollment #672

Merged
merged 5 commits into from
Feb 23, 2025
Merged

Normalize enrollment #672

merged 5 commits into from
Feb 23, 2025

Conversation

ekoby
Copy link
Member

@ekoby ekoby commented Feb 21, 2025

  • enrollment now creates IdentityConfig
  • better enrollment java interop
  • integration test for enrollment

ekoby added 4 commits February 19, 2025 10:56
@ekoby
add native serialization
e4fbf0c
@ekoby
make IdentityConfig public
404111e
@ekoby
enrollment improvements
481ef4f 
- enrollment now creates IdentityConfig
- better enrollment java interop
- integration test for enrollment
@ekoby
test compiling of samples
b8ef250
@ekoby ekoby requested a review from a team as a code owner February 21, 2025 16:53
@ekoby ekoby added the major Bump major version label Feb 21, 2025
dovholuknf
dovholuknf reviewed Feb 21, 2025
View reviewed changes
ziti/src/test/kotlin/org/openziti/IdentityConfigTest.kt
],
"id":{
"cert":"-----BEGIN CERTIFICATE-----\nMIIDjzCCAXegAwIBAgIDAMi2MA0GCSqGSIb3DQEBCwUAMG0xCzAJBgNVBAYTAlVT\nMRIwEAYDVQQHEwlDaGFybG90dGUxEzARBgNVBAoTCk5ldEZvdW5kcnkxEDAOBgNV\nBAsTB0FEVi1ERVYxIzAhBgNVBAMTGmludGVybWVkaWF0ZS1jYS1xdWlja3N0YXJ0\nMB4XDTI1MDIxODE5NDIyNVoXDTI2MDIxODE5NDMyNVowKDERMA8GA1UEChMIT3Bl\nblppdGkxEzARBgNVBAMTCkRsdzBRM09tb1EwWTATBgcqhkjOPQIBBggqhkjOPQMB\nBwNCAAR0DtFWsxJVi6yJxcH8OAHsKp3WLoTTnwhTZcYTjVARxYKZMGWsziVAAuuZ\nPb1NV4skL1LvITGQgK1wAjUwU4s5o0gwRjAOBgNVHQ8BAf8EBAMCBLAwEwYDVR0l\nBAwwCgYIKwYBBQUHAwIwHwYDVR0jBBgwFoAUea/7+V+MNel79c7p6J2SBya1fnww\nDQYJKoZIhvcNAQELBQADggIBAKea6m0qpUcG0Ce05XdS9pcO0I8lZuCaXVqh0pVo\nj0PtWmrVu/euXaCsV2ENJricGV49FtQmiHS4eo1wt34LddKjUNtsCqHRsguBSlEl\nHqqdZgC07kymR3rJ12sK3/HPuF53HmlTZtxo9O4HNEtJjhszG3XPsUDTWoKBDCZE\n9ZN68jOIILrRY1OLPDF7u8KaECAHzVJt5qmxlMcyo6GKnnbYbtFTwWa0qfBxK1N2\ngmxNjNcAUJGdm0Xb1bL+YzFRo4mQP66/lDL0U3rXfjox1ra0zTu9gB2OxRw2r5Uu\nFYB0zwRbjvRp6wOffFBn8Z6i9sbP+a4vp7Tbny/KbGi4I02ViMcgWN1m7VGcpuKV\nAynV6PCL9JTJlqlpBUrShqqNzxGIEzUJMhFdEys+DVKirlf0NzoStR/jp5KQKOoi\nwFHx872xKaPatvZRPKxIdkVyNpaK/YI6bOOd50lULBeJs4XCWGVxeMRHAH+/EoMq\nBItCywy9Qsab5PS7qN+2XYe+NsBS/5jSknbzJx+zWczZMV2xBGp95bM6PyANoSkM\ne2dRTVwwjpBciOzvr5ZUy0Xr/iheOZuDap46+s8fC0V988Rbe9dyo9TgzsJ2MRMu\nsRN1HNNLmoQAI42brAHQJeWmao428L4rBm2AHkQHrDqYMwX8oUElLA/g4PdT3iZf\nLwP4\n-----END CERTIFICATE-----\n-----BEGIN CERTIFICATE-----\nMIIF2TCCA8GgAwIBAgIQMgjOt/XGqGSMmMEgTIhxezANBgkqhkiG9w0BAQsFADBa\nMQswCQYDVQQGEwJVUzESMBAGA1UEBxMJQ2hhcmxvdHRlMRMwEQYDVQQKEwpOZXRG\nb3VuZHJ5MRAwDgYDVQQLEwdBRFYtREVWMRAwDgYDVQQDEwdyb290LWNhMB4XDTI1\nMDIxODE5NDEyNFoXDTM1MDIxNjE5NDIyMlowbTELMAkGA1UEBhMCVVMxEjAQBgNV\nBAcTCUNoYXJsb3R0ZTETMBEGA1UEChMKTmV0Rm91bmRyeTEQMA4GA1UECxMHQURW\nLURFVjEjMCEGA1UEAxMaaW50ZXJtZWRpYXRlLWNhLXF1aWNrc3RhcnQwggIiMA0G\nCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQDRx87QdwtweFZ0hsRhMyFSbZPVdaC3\nmjTD8lDGugilDOV2nIjv7WdfcTMgct3/g0f8mHGPauKs/uL+cArAAyapP6t1DYC5\ntmG6+LuqFjlb+bcY5oYvPBLeBi8UEk95258+74URRLE5bK6JiH95rs/fdIjsVhpo\nsPfQDZq3RXYByfCk98UGoah+7YsEK07LDn+ykXrBmCogN2mWU6ZxImnbiJXt/J7S\nAG6pDkFqrhJnSkGErx5Q8vIv7qDr3FtVALcx29ndZUFUG0580f3E7ZSony2OAEvG\nnN1R2/el2FZEbINYGn95oYN/AyNtzq0aYKHfXoi30DI9sjzbEQkeEaiAaNm+GqdX\nRWIPemUDPglaMu8Jo9UK+HPWGkkw8AdclmVk3KBB2CM78fcPmDmQ772to6hrUNVi\nD/rlhVwypVq7HAnXvCF7crxiNndhh9zGhUOsFFpS/aecVIKaeN2kUK9oTMGoYMxR\nUzYF+YvGN+3UeBtMaGcmUaSw2VA4QqE+1UNmudYm6pgykQ6ai/rF6GvUKuDJxisU\n43nHxzWRSwZikM3i0EhNnmhqf94vVuIcuIJucAH4ZdHFelh045l9DLgWi2KcKfqv\nGxpbgn95LhAPlINGo04NK8xGnVT8EQWC/eKsSh4kC9mBLlSkqG8m5xjxhdyJgFER\nt8DSMRHCyHgHvQIDAQABo4GHMIGEMA4GA1UdDwEB/wQEAwIBhjASBgNVHRMBAf8E\nCDAGAQH/AgEBMB0GA1UdDgQWBBR5r/v5X4w16Xv1zunonZIHJrV+fDAfBgNVHSME\nGDAWgBQlKAdnL4josYQt42xKrv/LhpmTgzAeBgNVHREEFzAVhhNzcGlmZmU6Ly9x\ndWlja3N0YXJ0MA0GCSqGSIb3DQEBCwUAA4ICAQBvJT7KLqKffAx80DcpPYF9xPbN\nMfW4sjom6B+1r9PrHerTplX2W6vleLP0gWnnNgwCSapXA+96G0Bn3ILc0HudiSb9\n3nlj97PZG66Ftj/ol8n7MQFyLPFedlQ4m1rsA2Mai8Exelp4aE6PifH+ykmzudS0\nDLxJzXG+hVlRf1DVIya8W8vL329KVXjEClxvSx0ay7lvCo8EIelGNPgyrFV+Khu5\nQNtr5xa9ysV+OS1yyg8BPi1J/bFXATTS9x20wvKOmLKk9AdtUhV0BmFWpqLkEjgI\nkvfPXhzqAJEbCjdyQbyZHhQpBKBRITZ7cpI71XGxJSj7hn0uZkceRbPGJ6StUA0r\nTnAWdnzVjscLKQTaSjS3OEqF6KF+G15xOa5CPNAfHMNGD8FCOMUXlxol5UtXnSN0\n7F/LAiktuZ2FnzconYsotWmBIVRyz5AKIibESqeQM8W4Yn3H/QIwDHnhHAAhUhpE\nltj5hMoETWxqi+s5iO8XhUkUBtT9AKEPcTSJSthq/efXcrg3DsoLstJDMosgqB7s\nooU5WjBfzMggXzD5NOIXyxz06u6+U0128Sxqnz44U1X3f+Y7do7gvLeEzvWOTU7s\nYfj24ODJxVHdHKHN0EWl91l+9DAsfzySKU5QPz+/zRMiKgL9OJhIjeC5PakDySOG\nvaST+lvNiqBbvgU5DA==\n-----END CERTIFICATE-----\n",
"key":"-----BEGIN PRIVATE KEY-----\nMIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgyh2aOTEM6t3G7Zh5\nO280GnMu/b7nvnoHOhaDMCKPyDehRANCAAR0DtFWsxJVi6yJxcH8OAHsKp3WLoTT\nnwhTZcYTjVARxYKZMGWsziVAAuuZPb1NV4skL1LvITGQgK1wAjUwU4s5\n-----END PRIVATE KEY-----\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm shocked github didn't flag this :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (or hope) that codeql recognizes test code

dovholuknf
dovholuknf approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@dovholuknf dovholuknf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments but lgtm

@ekoby ekoby merged commit 6fe4c52 into main Feb 23, 2025
10 checks passed
@ekoby ekoby deleted the normalize-enrollment branch February 23, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dovholuknf dovholuknf dovholuknf approved these changes

Assignees
No one assigned
Labels
major Bump major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekoby @dovholuknf