Release OpenProject 14.5.0

.dockerignore

@@ -22,11 +22,18 @@ browserslist
 !/docs/api/apiv3/tags
 !/docs/api/apiv3/components
 
+# Ignore spec/** folders
+spec/**
+# Allow factories in case we use lookbook
+!spec/factories
+!spec/factories/**
+!spec/support
+!spec/support/**
+
 extra
 features
 help
 log/*.log
-spec
 /tmp
 frontend/.angular/cache
 frontend/node_modules

.env.example

@@ -1,6 +1,6 @@
 #-- copyright
 # OpenProject is an open source project management software.
-# Copyright (C) 2012-2020 the OpenProject GmbH
+# Copyright (C) the OpenProject GmbH
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License version 3.

.env.test.local.example

@@ -1,6 +1,6 @@
 #-- copyright
 # OpenProject is an open source project management software.
-# Copyright (C) 2012-2020 the OpenProject GmbH
+# Copyright (C) the OpenProject GmbH
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License version 3.

.git-blame-ignore-revs

@@ -1,14 +1,12 @@
 # .git-blame-ignore-revs
-# lint with rubocop --autocorrect (safe cops only)
-48a4f1b6adb1e847a90a61f2ab277f28bcd77608
-# Update copyright information for 2023
-21a696ef9b170e14ad2daf53364a4c2113822c2f
-# Update copyright information for 2024
-c795874f7f281297bbd3bad2fdb58b24cb4ce624
 # rubocop autocorrections
+48a4f1b6adb1e847a90a61f2ab277f28bcd77608
 f3c99ee5dded81ad55f2b6f3706216d5fa765677
 5c72ea0046a6b5230bf456f55a296ed6fd579535
 9e4934cd0a468f46d8f0fc0f11ebc2d4216f789c
 6678cab48d443b5782fa93b171d62093819ee4fc
 fa5d03eae00bc8931f99598a74ffd76e0cbca3da
 b10e6d718cc49e3574837d97fab268e3ecb3fcbd
+# accidental merge
+7787e457a37d8d1ef5b6d0c2e326bdc42338ac7b
+3b2121f7333f0ce7f3515b29c760c0580c31a245

.github/pull_request_template.md

@@ -1,6 +1,9 @@
-<!-- Contributors: Please check our [PR guide](https://www.openproject.org/docs/development/code-review-guidelines/#preparing-your-pull-request) before opening a PR. -->
+# Ticket
+<!-- Provide the link to respective work package -->
+
+<!-- Contributors: Please check our PR guide: https://www.openproject.org/docs/development/code-review-guidelines/#preparing-your-pull-request before opening a PR. -->
 
-<!-- Reviewers: Please check our [Review guide](https://www.openproject.org/docs/development/code-review-guidelines/#reviewing) -->
+<!-- Reviewers: Please check our Review guide: https://www.openproject.org/docs/development/code-review-guidelines/#reviewing -->
 
 # What are you trying to accomplish?
 <!-- Provide a description of the changes. -->
@@ -13,9 +16,6 @@
      List any tradeoffs you made to take on or pay down tech debt.
      Describe any alternative approaches you considered and why you discarded them. -->
 
-# Ticket
-<!-- Provide the link to respective work package -->
-
 # Merge checklist
 
 - [ ] Added/updated tests

.github/workflows/i18n-tasks.yml

@@ -0,0 +1,44 @@
+name: i18n-inconsistency-check
+
+on:
+  push:
+    branches:
+      - dev
+      - release/*
+    paths-ignore:
+      - 'docs/**'
+      - 'help/**'
+  pull_request:
+    types: [opened, reopened, synchronize]
+    paths-ignore:
+      - 'docs/**'
+      - 'help/**'
+      - 'packaging/**'
+      - '.pkgr.yml'
+
+permissions:
+  contents: read
+
+jobs:
+  i18n-tasks:
+    permissions:
+      contents: read
+    if: github.repository == 'opf/openproject'
+    name: I18n inconsistency check
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+
+      - name: Setup i18n-tasks
+        run: |
+          gem install i18n-tasks
+
+      - name: Run inconsistent translations check
+        run: |
+          i18n-tasks \
+            check-consistent-interpolations \
+            --config config/i18n-tasks-all-files.yml

.github/workflows/test-core.yml

@@ -27,6 +27,7 @@ jobs:
       labels:
         - runs-on
         - runner=32cpu-linux-x64
+        - family=m7
         - run-id=${{ github.run_id }}
     timeout-minutes: 40
     env:

.gitignore

@@ -1,6 +1,6 @@
 #-- copyright
 # OpenProject is an open source project management software.
-# Copyright (C) 2012-2022 the OpenProject GmbH
+# Copyright (C) the OpenProject GmbH
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License version 3.

.rubocop.yml

@@ -208,6 +208,17 @@ Rails/DynamicFindBy:
     - 'spec/features/**/*.rb'
     - 'spec/support/**/*.rb'
     - 'modules/*/spec/features/**/*.rb'
+  Whitelist:
+    - find_by_login
+
+# Allow reorder to prevent find each cop triggering
+Rails/FindEach:
+  AllowedMethods:
+    - order
+    - reorder
+    - limit
+    - select
+    - lock
 
 # We have config.active_record.belongs_to_required_by_default = false ,
 # which means, we do have to declare presence validators on belongs_to relations.

COPYRIGHT_short

@@ -1,5 +1,5 @@
 OpenProject is an open source project management software.
-Copyright (C) 2012-2024 the OpenProject GmbH
+Copyright (C) the OpenProject GmbH
 
 This program is free software; you can redistribute it and/or
 modify it under the terms of the GNU General Public License version 3.

Gemfile

@@ -1,6 +1,6 @@
 #-- copyright
 # OpenProject is an open source project management software.
-# Copyright (C) 2012-2024 the OpenProject GmbH
+# Copyright (C) the OpenProject GmbH
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License version 3.
@@ -63,7 +63,7 @@ gem "acts_as_list", "~> 1.2.0"
 gem "acts_as_tree", "~> 2.9.0"
 gem "awesome_nested_set", "~> 3.6.0"
 gem "closure_tree", "~> 7.4.0"
-gem "rubytree", "~> 2.0.0"
+gem "rubytree", "~> 2.1.0"
 # Only used in down migrations now.
 # Is to be removed once the referencing migrations have been squashed.
 gem "typed_dag", "~> 2.0.2", require: false
@@ -165,7 +165,7 @@ gem "ttfunk", "~> 1.7.0" # remove after https://github.com/prawnpdf/prawn/issues
 # prawn implicitly depends on matrix gem no longer in ruby core with 3.1
 gem "matrix", "~> 0.4.2"
 
-gem "meta-tags", "~> 2.21.0"
+gem "meta-tags", "~> 2.22.0"
 
 gem "paper_trail", "~> 15.1.0"
 
@@ -204,14 +204,15 @@ gem "plaintext", "~> 0.3.2"
 
 gem "ruby-progressbar", "~> 1.13.0", require: false
 
-gem "mini_magick", "~> 4.13.0", require: false
+gem "mini_magick", "~> 5.0.1", require: false
 
 gem "validate_url"
 
 # Storages support code
 gem "dry-auto_inject"
 gem "dry-container"
 gem "dry-monads"
+gem "dry-validation"
 
 # ActiveRecord extension which adds typecasting to store accessors
 gem "store_attribute", "~> 1.0"
@@ -240,7 +241,7 @@ group :test do
 
   # Test prof provides factories from code
   # and other niceties
-  gem "test-prof", "~> 1.3.0"
+  gem "test-prof", "~> 1.4.0"
   gem "turbo_tests", github: "opf/turbo_tests", ref: "with-patches"
 
   gem "rack_session_access"
@@ -274,7 +275,7 @@ group :test do
   gem "selenium-devtools"
   gem "selenium-webdriver", "~> 4.20"
 
-  gem "fuubar", "~> 2.5.0"
+  gem "fuubar", "~> 2.5.0", require: false
   gem "timecop", "~> 0.9.0"
 
   # Record your test suite's HTTP interactions and replay them during future test runs for fast, deterministic, accurate tests.
@@ -321,6 +322,9 @@ group :development, :test do
   gem "ruby-prof", require: false
   gem "stackprof", require: false
 
+  # Output a stack trace anytime, useful when a process is stuck
+  gem "rbtrace"
+
   # REPL with debug commands
   gem "debug"
 
@@ -347,7 +351,7 @@ group :development, :test do
   gem "brakeman", "~> 6.1.0"
 
   # i18n-tasks helps find and manage missing and unused translations.
-  gem "i18n-tasks", "~> 1.0.13"
+  gem "i18n-tasks", "~> 1.0.13", require: false
 end
 
 gem "bootsnap", "~> 1.18.0", require: false
@@ -392,6 +396,6 @@ gemfiles.each do |file|
   send(:eval_gemfile, file) if File.readable?(file)
 end
 
-gem "openproject-octicons", "~>19.17.0"
-gem "openproject-octicons_helper", "~>19.17.0"
-gem "openproject-primer_view_components", "~>0.40.0"
+gem "openproject-octicons", "~>19.18.0"
+gem "openproject-octicons_helper", "~>19.18.0"
+gem "openproject-primer_view_components", "~>0.43.1"