Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/58159 fixed set of project stages and gates editable on project overview page #17119

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Nov 5, 2024

Ticket

https://community.openproject.org/wp/59287

What are you trying to accomplish?

Add the foundation structure for the Stages and Gates epic. It consists of:

  • Adding a feature flag
  • Adding the stages and gates set up as instance wide models
  • Setting up Project related stages and gates models
  • Seeding a predefined set of stages and gates as outlined in PM2 specification
  • Translating the predefined seeds (Happens on Crowdin)
  • Handle data migration for existing instances
  • Add newly specced Gate seeds

What approach did you choose and why?

The approach chosen is to have a base model called LifeCycle to share behaviour between the Stage and Gate models. Stage and Gate models are mostly the same, except the type.

Additionally a second set of project specific Project::LifeCycle models are defined alongside with Project::Stage and Project::Gate. These models hold project specific information about each LifeCycle, such as the start and end dates of life cycles defined inside each project. The Project::Stage required a start_date and end_date fields, while the Project::Gate requires a date field. These are all mapped in the Project::LifeCycle model with STI.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz dombesz force-pushed the feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page branch 2 times, most recently from 31b50a2 to 952f65f Compare November 6, 2024 20:47
@dombesz dombesz force-pushed the feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page branch 2 times, most recently from bb422e9 to fb7881b Compare November 12, 2024 19:59
@dombesz dombesz marked this pull request as ready for review November 13, 2024 10:30
@dombesz dombesz force-pushed the feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page branch from fb7881b to df3f826 Compare November 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant