-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/58159 fixed set of project stages and gates editable on project overview page #17119
Open
dombesz
wants to merge
13
commits into
dev
Choose a base branch
from
feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/58159 fixed set of project stages and gates editable on project overview page #17119
dombesz
wants to merge
13
commits into
dev
from
feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombesz
force-pushed
the
feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page
branch
2 times, most recently
from
November 6, 2024 20:47
31b50a2
to
952f65f
Compare
dombesz
force-pushed
the
feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page
branch
2 times, most recently
from
November 12, 2024 19:59
bb422e9
to
fb7881b
Compare
dombesz
force-pushed
the
feature/58159-fixed-set-of-project-stages-and-gates-editable-on-project-overview-page
branch
from
November 13, 2024 15:12
fb7881b
to
df3f826
Compare
…ared across projects.
…Gate templates in an OP instance.
…existing colors to be looked up
…fter a version upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59287
What are you trying to accomplish?
Add the foundation structure for the Stages and Gates epic. It consists of:
Translating the predefined seeds(Happens on Crowdin)What approach did you choose and why?
The approach chosen is to have a base model called
LifeCycle
to share behaviour between theStage
andGate
models.Stage
andGate
models are mostly the same, except the type.Additionally a second set of project specific
Project::LifeCycle
models are defined alongside withProject::Stage
andProject::Gate
. These models hold project specific information about eachLifeCycle
, such as the start and end dates of life cycles defined inside each project. TheProject::Stage
required astart_date
andend_date
fields, while theProject::Gate
requires adate
field. These are all mapped in theProject::LifeCycle
model with STI.Merge checklist