Impl/63469 rename restricted to internal comments #18669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopagno
changed the base branch from
dev
to
implementation/63384-on-edit-set-attachment-replacements
brunopagno
changed the base branch from
implementation/63384-on-edit-set-attachment-replacements
to
dev
brunopagno
changed the base branch from
dev
to
implementation/63384-on-edit-set-attachment-replacements
Base automatically changed from
implementation/63384-on-edit-set-attachment-replacements
to
dev
April 22, 2025 06:55
brunopagno
force-pushed
the
impl/63469-rename-restricted-to-internal-comments
branch
4 times, most recently
from
7b303c5 to
e9899b6
Compare
akabiru
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
🥇 quite a chunky one, thanks for taking care of this @brunopagno !
lgtm, just left a few file renames that got left out. 👍🏾
| @@ -123,6 +123,8 @@ class Journal < ApplicationRecord | |||
| scope :for_work_package, -> { where(journable_type: "WorkPackage") } | |||
| scope :for_meeting, -> { where(journable_type: "Meeting") } | |||
|
|
|||
| alias_attribute :internal, :restricted | |||
Comment on lines
+43
to
+49
| def rename_permissions(old, new) | ||
| execute <<-SQL.squish | ||
| UPDATE role_permissions | ||
| SET permission = '#{new}' | ||
| WHERE permission = '#{old}' | ||
| SQL | ||
| end |
There was a problem hiding this comment.
👍🏾 @machisuji should be happy 😉
3 tasks
brunopagno
force-pushed
the
impl/63469-rename-restricted-to-internal-comments
branch
from
eb9d0d2 to
d14e079
Compare
brunopagno
force-pushed
the
impl/63469-rename-restricted-to-internal-comments
branch
from
d14e079 to
fe708d5
Compare
brunopagno
deleted the
impl/63469-rename-restricted-to-internal-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/63469
depends on https://github.com/opf/openproject-token/pull/22
What are you trying to accomplish?
Rename comments with restricted visibility to internal comments
What approach did you choose and why?
Renaming permissions, and strings, and internal representations. Risk of breaking things.