Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[26829] Patch reform-rails to use activerecord i18n_scope #6105

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Jan 8, 2018

The validator passed to AM::Error does not use the i18n_scope we
define on either Reform::Form or the model, but is delegated from the
included AM::Translations module.

This in turn causes I18n to lookup the scope :activemodel, failing the
localization.

trailblazer/reform-rails#56
trailblazer/reform-rails#35

https://community.openproject.com/wp/26829

The validator passed to AM::Error does not use the `i18n_scope` we
define on either Reform::Form or the model, but is delegated from the
included AM::Translations module.

This in turn causes I18n to lookup the scope `:activemodel`, failing the
localization.

trailblazer/reform-rails#56
trailblazer/reform-rails#35
@oliverguenther oliverguenther merged commit 3facc58 into dev Jan 9, 2018
@oliverguenther oliverguenther deleted the fix/26829/i18n-reform branch January 9, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant