Do not overwrite custom data attributes but rather ammend to it

opf · Sep 10, 2024 · cd175c4 · cd175c4
1 parent f6b37f6
commit cd175c4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/.changeset/wicked-crews-provide.md b/.changeset/wicked-crews-provide.md
@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': patch
+---
+
+Do not overwrite custom data attributes
diff --git a/app/components/primer/open_project/sub_header.rb b/app/components/primer/open_project/sub_header.rb
@@ -47,22 +47,14 @@ class SubHeader < Primer::Component
         system_arguments[:input_width] ||= :medium
 
         system_arguments[:data] ||= {}
-        system_arguments[:data][:target]= "sub-header.filterInput"
+        system_arguments[:data][:target] ||= ""
+        system_arguments[:data][:target] += " sub-header.filterInput"
 
         system_arguments[:show_clear_button] = true if system_arguments[:show_clear_button].nil?
 
         if system_arguments[:show_clear_button]
-          system_arguments[:data] = merge_data(
-            system_arguments,
-            {
-              data: {
-                action: <<~JS
-                  input:sub-header#toggleFilterInputClearButton
-                  focus:sub-header#toggleFilterInputClearButton
-                JS
-              }
-            }
-          )
+          system_arguments[:data][:action] ||= ""
+          system_arguments[:data][:action] += " input:sub-header#toggleFilterInputClearButton focus:sub-header#toggleFilterInputClearButton"
         end
 
         @mobile_filter_trigger = Primer::Beta::IconButton.new(icon: system_arguments[:leading_visual][:icon],