Code

Feat hide clear button#174

Code

Merged

HDinger merged 15 commits intomainopf/primer_view_components:mainfrom feat-hide-clear-buttonopf/primer_view_components:feat-hide-clear-buttonCopy head branch name to clipboardSep 10, 2024

+151-5

Commits

Commits on Sep 6, 2024

• Automatically toggle the clear button on the filterInput of the SubHeader component.

  dombesz

  committed
  ee9c187

  Copy full SHA for ee9c187

• Simplify clearFilterButton implementation.

  dombesz

  committed
  bf09d93

  Copy full SHA for bf09d93

• Add changeset

  dombesz

  committed
  094888a

  Copy full SHA for 094888a

• Add SubHeader component tests

  dombesz

  committed
  01cd60c

  Copy full SHA for 01cd60c

• Add mutation observer for finding the clear button

  dombesz

  committed
  ca2ae45

  Copy full SHA for ca2ae45

• Move out the querySelector from the connectedCallback

  dombesz

  committed
  1071426

  Copy full SHA for 1071426

• Try disabling compatibility check

  dombesz

  committed
  d0adae6

  Copy full SHA for d0adae6

• Fix linter issues

  dombesz

  committed
  1931115

  Copy full SHA for 1931115

• Enable Vite compatibility check

  dombesz

  committed
  a33d92f

  Copy full SHA for a33d92f

Commits on Sep 9, 2024

• Address CR comments.

  dombesz

  committed
  816a977

  Copy full SHA for 816a977

• Make show_clear_button default to true

  dombesz

  committed
  9b1a35b

  Copy full SHA for 9b1a35b

• Fix tests

  dombesz

  committed
  2067dad

  Copy full SHA for 2067dad

• Remove unnecessary variable

  dombesz

  committed
  f4f7ec4

  Copy full SHA for f4f7ec4

• Fix clear button flickering on page load

  dombesz

  committed
  06ca3d9

  Copy full SHA for 06ca3d9

Commits on Sep 10, 2024

• Simplify catalyst controller as only the class needs to be toggled to hide the clear button

  HDinger

  committed
  7b3ed15

  Copy full SHA for 7b3ed15