Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing step to "How to run" instructions #212

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

myabc
Copy link

@myabc myabc commented Dec 6, 2024

What are you trying to accomplish?

Keeping documentation accurate and up-to-date.

Screenshots

n/a

Integration

n/a

List the issues that this change affects.

Adds a missing step to the "How to run" instructions.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

n/a

Anything you want to highlight for special attention from reviewers?

n/a

Accessibility

n/a

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@HDinger HDinger added the skip changeset For PRs that contain no relevant release data (e.g. documentation only) label Dec 6, 2024
@myabc myabc merged commit 2304f25 into main Dec 6, 2024
36 of 37 checks passed
@myabc myabc deleted the fix/missing-step-in-setup.md branch December 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset For PRs that contain no relevant release data (e.g. documentation only)
Development

Successfully merging this pull request may close these issues.

2 participants