Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx DangerConfirmationDialog internal components status #224

Merged

Conversation

myabc
Copy link

@myabc myabc commented Jan 13, 2025

What are you trying to accomplish?

Status should be open_project.

Screenshots

Integration

List the issues that this change affects.

N/A

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

myabc added 2 commits January 13, 2025 14:29
Internal components shou also be of status `openproject` rather than the
default, `alpha`.
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 927f527

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myabc
Copy link
Author

myabc commented Jan 13, 2025

@HDinger Is status just meta-data for documentation? I think we can skip changeset here?

@HDinger
Copy link
Collaborator

HDinger commented Jan 14, 2025

@HDinger Is status just meta-data for documentation? I think we can skip changeset here?

I agree. For that case, there is a skip changeset label which you can add on a PR. The CI step is then ignored and the PR turns green.

@HDinger HDinger added the skip changeset For PRs that contain no relevant release data (e.g. documentation only) label Jan 14, 2025
@HDinger HDinger merged commit 2deecbd into main Jan 14, 2025
36 of 37 checks passed
@HDinger HDinger deleted the fix/danger_confirmation_dialog-internal-components-missing-status branch January 14, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset For PRs that contain no relevant release data (e.g. documentation only)
Development

Successfully merging this pull request may close these issues.

2 participants