Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api changes after buf lint errors #431

Merged

Conversation

artek-koltun
Copy link
Collaborator

@artek-koltun artek-koltun commented Jan 19, 2024

API change in opiproject/opi-api#419

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (742ee44) 66.43% compared to head (1463679) 66.43%.

Files Patch % Lines
storage/goopicsi.go 25.00% 3 Missing ⚠️
network/bridge_port.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files          15       15           
  Lines        1275     1275           
=======================================
  Hits          847      847           
  Misses        395      395           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun marked this pull request as ready for review January 19, 2024 12:28
@artek-koltun artek-koltun requested a review from a team as a code owner January 19, 2024 12:28
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

Copy link
Collaborator Author

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged forcefully to break the circular dependency while it is being discussed how to overcome it

@artek-koltun artek-koltun merged commit 0ba322a into opiproject:main Jan 22, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants