Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage/nvme): add cli for backend nvme path #433

Merged

Conversation

artek-koltun
Copy link
Collaborator

@artek-koltun artek-koltun commented Jan 22, 2024

Exemplary cmds to connect to a remote NVMe/TCP controller:

# Connect to remote NVMe/TCP controller
nvmf0=$(go run . storage create backend nvme controller --id nvmef0 --multipath failover)
path0=$(go run . storage create backend nvme path tcp --controller "$nvmf0" --id path0 --ip 127.0.0.1 --port 4420 --nqn nqn.2019-06.io.spdk:0)
go run . storage delete backend nvme path --name $path0
go run . storage delete backend nvme controller --name $nvmf0

# Connect to a PCIe NVMe controller
nvme0=$(go run . storage create backend nvme controller --id nvmee0 --multipath disable)
path0=$(go run . storage create backend nvme path pcie --controller "$nvme0" --id path0 --bdf "0000:65:00.0")
go run . storage delete backend nvme path --name $path0
go run . storage delete backend nvme controller --name $nvme0

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ba322a) 67.64% compared to head (368fc65) 69.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   67.64%   69.27%   +1.62%     
==========================================
  Files          17       18       +1     
  Lines        1323     1393      +70     
==========================================
+ Hits          895      965      +70     
  Misses        395      395              
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun force-pushed the feat-add-cli-for-nvme-tcp-path branch from e5035b1 to 368fc65 Compare January 22, 2024 11:09
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun marked this pull request as ready for review January 22, 2024 11:25
@artek-koltun artek-koltun requested a review from a team as a code owner January 22, 2024 11:25
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandersms sandersms merged commit 0d88974 into opiproject:main Jan 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants